Loudness related thing support #60
Conversation
|
I see you've updated this so it can be merged! I'm excited to take a close look at this PR soon. :) |
| rms = Math.max(rms, this._lastValue * 0.6); | ||
| } | ||
| this._lastValue = rms; | ||
| rms *= 1.63; |
There was a problem hiding this comment.
This seems to be missing a lot of explanatory comments from Scratch's implementation.
| this.fireGreatherThanTrigger(Trigger.LOUDNESS_GREATER_THAN); | ||
| } | ||
| this._prevLoudness = this.loudnessHandler.loudness; | ||
| this.fireGreatherThanTrigger(Trigger.TIMER_GREATER_THAN); |
There was a problem hiding this comment.
Scratch seems to implement "edge-activated hats" (what we call "greater-than triggers" here) a bit differently--every step, it evaluates the predicate of the hat (e.g. "is loudness greater than N? is timer greater than N?") which returns either a true or false value. It fires those hat blocks if the predicate evaluates to true and it evaluated to false on the previous step (the predicate is on a rising edge).
This seems like it'd require less per-trigger logic, and the predicate logic can be encapsulated more cleanly. Would that be worth doing?
| @@ -305,6 +304,10 @@ class SpriteBase { | |||
| get answer() { | |||
| return this._project.answer; | |||
| } | |||
|
|
|||
| async loudness() { | |||
| return this._project.loudnessHandler.getLoudness(); | |||
There was a problem hiding this comment.
It looks like Scratch only recomputes loudness once per step.
This adds LoudnessHandler, which is mostly copy-paste from scratch-audio. Also, adds
Project.fireGreaterThanTriggerandTrigger.getOption/Trigger.castOptionas well asTrigger.executed. In terms of blocks, it addsloudnessandwhen () > ()trigger.