-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the "loudness" block and "loudness greater than" trigger #137
Conversation
I am confused... I changed nothing, but an hour later, Edit: Aaaaaannnd now it's broken again. |
Oh, I see. Chrome has been giving me the following warning for a long time now (since long before this PR):
I assumed this was for playing sounds only, but it appears that the microphone access also relies on |
Only try to connect if we're in the "never tried to connect" state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behavior looks good now 👍
(@towerofnix said they might be away, so I removed them as a reviewer.)
Based on @apple502j's work, with some refactoring and rebasing to work with the new edge-activated trigger code and also clean up the code a bit.
Resolves #122 and closes #60.