Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add component: Button #40

Closed
niloysikdar opened this issue Jun 30, 2022 · 0 comments · Fixed by #47
Closed

add component: Button #40

niloysikdar opened this issue Jun 30, 2022 · 0 comments · Fixed by #47
Assignees
@niloysikdar
Labels
2 2 story points GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Milestone
GSoC 2022 - Sprint D

Comments

@niloysikdar
Copy link
Member

Description:

  • Add component - Button
  • Variation: primary | secondary
  • Use a tag under the hood

Outcome:

  • New Button component
  • Add PropTypes for the components
  • Add Storybook story
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Jun 30, 2022
@niloysikdar niloysikdar self-assigned this Jun 30, 2022
niloysikdar added a commit that referenced this issue Jun 30, 2022
@niloysikdar
feat(component): add button
55cf6de 
add button component

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jun 30, 2022
@niloysikdar
docs(storybook): add stories for button
d677e56 
add new stories for button component

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Jun 30, 2022
Merged
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
fix(component): fix Button component
baeb0d9 
fix Button component types to extend from BaseStyles and add classes to the props list
fix BaseStyles to convert Record as Partial to make things optional

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
feat(component): add button
be32759 
add button component

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
docs(storybook): add stories for button
cb22cb1 
add new stories for button component

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
fix(component): fix Button component
6b24d6c 
fix Button component types to extend from BaseStyles and add classes to the props list
fix BaseStyles to convert Record as Partial to make things optional

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
fix(component): fix Button component
af05f67 
fix Button component types to extend from BaseStyles and add classes to the props list
fix BaseStyles to convert Record as Partial to make things optional

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
fix(component): fix Button component
f0880bd 
fix Button component types to extend from BaseStyles and add classes to the props list
fix BaseStyles to convert Record as Partial to make things optional

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
docs(stories): add stories for Button
ccb9735 
add new stories for Button components with Primary and Secondary variants

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 5, 2022
@niloysikdar
docs(stories): add stories for Button
309e612 
add new stories for Button components with Primary and Secondary variants

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
agentmilindu pushed a commit that referenced this issue Jul 5, 2022
@niloysikdar
feat(component): add button component (#47)
c846451 
* feat(component): add button

add button component

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* docs(storybook): add stories for button

add new stories for button component

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* fix(component): fix Button component

fix Button component types to extend from BaseStyles and add classes to the props list
fix BaseStyles to convert Record as Partial to make things optional

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* docs(stories): add stories for Button

add new stories for Button components with Primary and Secondary variants

resolves #40

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
github-actions bot pushed a commit that referenced this issue Jul 5, 2022
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
a6813d8 
# [1.1.0](v1.0.1...v1.1.0) (2022-07-05)

### Features

* **component:** add button component ([#47](#47)) ([c846451](c846451)), closes [#40](#40) [#40](#40) [#40](#40) [#40](#40)
* **component:** add column and section ([#46](#46)) ([c89ad5e](c89ad5e)), closes [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39)
@agentmilindu agentmilindu added the 2 2 story points label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
2 2 story points GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Projects
React Email
Status: Released
Milestone
GSoC 2022 - Sprint D
Development

Successfully merging a pull request may close this issue.

feat(component): add button component leopardslab/react-email
2 participants
@agentmilindu @niloysikdar