Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add component: Column and Section #39

Closed
niloysikdar opened this issue Jun 30, 2022 · 0 comments · Fixed by #46
Closed

add component: Column and Section #39

niloysikdar opened this issue Jun 30, 2022 · 0 comments · Fixed by #46
Assignees
@niloysikdar
Labels
3 3 story points GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Milestone
GSoC 2022 - Sprint D

Comments

@niloysikdar
Copy link
Member

Description:

  • Add components - Column & Section

Outcome:

  • New Column and Section component
  • Add PropTypes for the components
  • Add Storybook story
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Jun 30, 2022
@niloysikdar niloysikdar self-assigned this Jun 30, 2022
niloysikdar added a commit that referenced this issue Jun 30, 2022
@niloysikdar
feat(component): add column
8d25dcc 
add column component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jun 30, 2022
@niloysikdar
feat(component): add section
eb04e13 
add section component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jun 30, 2022
@niloysikdar
fix(component): fix email component
94cfd57 
fixed email component with updated tags

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jun 30, 2022
@niloysikdar
docs(storybook): fix email stories
18e9ffc 
fix email stories with the updated component structure

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jun 30, 2022
@niloysikdar
docs(storybook): add stories for column
2541664 
add missing stories for column component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jun 30, 2022
@niloysikdar
docs(storybook): stories for section
2c77ed7 
add stories for section component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Jun 30, 2022
Merged
niloysikdar added a commit that referenced this issue Jul 3, 2022
@niloysikdar
fix(components): fix Email, Section, Column
070f010 
fix the structure of Email, Section and Column components

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 3, 2022
@niloysikdar
docs(storybook): fix Email stories
052e9b9 
fix Email stories with the new structure

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 3, 2022
@niloysikdar
docs(storybook): fix Section stories
2d65b20 
fix Section stories with new structure

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 3, 2022
@niloysikdar
docs(storybook): fix Column stories
d0b1e21 
fix Column stories

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 3, 2022
@niloysikdar
feat(props): export props
c11c5aa 
export props for components from the library

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 3, 2022
@niloysikdar
fix(component): fix Email component
a06231b 
fix Email component with classes

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 3, 2022
@niloysikdar
fix(types): fix types props for Email
83d8a9b 
fix types using Record and add styles to the prop for Email component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 3, 2022
@niloysikdar
fix(types): fix types and props for Column
d23db71 
fix types to use Record and add styles props for Column component
fix stories for Column with styles

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
fix(types): fix types and props for Column
579f073 
fix types to use Record and add styles props for Column component
fix stories for Column with styles

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jul 4, 2022
@niloysikdar
fix(component): fix types and props name
f8368a7 
fix types with extends BaseStyleProp and adding classes to the props list

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
agentmilindu pushed a commit that referenced this issue Jul 4, 2022
@niloysikdar
feat(component): add column and section (#46)
c89ad5e 
* feat(component): add column

add column component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* feat(component): add section

add section component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* fix(component): fix email component

fixed email component with updated tags

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* docs(storybook): fix email stories

fix email stories with the updated component structure

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* docs(storybook): add stories for column

add missing stories for column component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* docs(storybook): stories for section

add stories for section component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* ci(storybook): fix storybook.yml

fix storybook.yml script to only deploy when push to main branch

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* fix(components): fix Email, Section, Column

fix the structure of Email, Section and Column components

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* docs(storybook): fix Email stories

fix Email stories with the new structure

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* docs(storybook): fix Section stories

fix Section stories with new structure

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* docs(storybook): fix Column stories

fix Column stories

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* feat(props): export props

export props for components from the library

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* fix(component): fix Email component

fix Email component with classes

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* fix(types): fix types props for Email

fix types using Record and add styles to the prop for Email component

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* fix(types): fix types and props for Column

fix types to use Record and add styles props for Column component
fix stories for Column with styles

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

* fix(component): fix types and props name

fix types with extends BaseStyleProp and adding classes to the props list

resolves #39

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
github-actions bot pushed a commit that referenced this issue Jul 5, 2022
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
a6813d8 
# [1.1.0](v1.0.1...v1.1.0) (2022-07-05)

### Features

* **component:** add button component ([#47](#47)) ([c846451](c846451)), closes [#40](#40) [#40](#40) [#40](#40) [#40](#40)
* **component:** add column and section ([#46](#46)) ([c89ad5e](c89ad5e)), closes [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39)
@agentmilindu agentmilindu added the 3 3 story points label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
3 3 story points GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Projects
React Email
Status: Released
Milestone
GSoC 2022 - Sprint D
Development

Successfully merging a pull request may close this issue.

feat(component): add column and section leopardslab/react-email
2 participants
@agentmilindu @niloysikdar