Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discord.py rewrite snippet file #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tilda
Copy link

@tilda tilda commented Jan 2, 2018

Fixes #17 (hopefully)
Mostly copied from the existing d.py file with a few tweaks.

@leovoel
Copy link
Owner

leovoel commented Jan 2, 2018

it needs to be added to this file: https://github.com/leovoel/embed-visualizer/blob/master/src/components/codemodal.jsx

i don't like the duplication here, though. i think i'd rather parametrize it and keep it in one file

@tilda
Copy link
Author

tilda commented Jan 2, 2018

Added to codemodal. About duplication, I agree. I don't really know much about react and js in general (aka "I've done some (basic) stuff with it" level) so I am not going to really touch parameters for now, until I look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants