[OBSOLETE] Fix setup.py requirements parsing with Pip 20+ #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterPhoenix
changed the title
|
As it turns out, the initial fix didn't work, so I went ahead and just made it parse them using file |
WinterPhoenix
added a commit
to solsticegamestudios/GModCEFCodecFix
that referenced
this pull request
Jun 19, 2020
…in requirements.txt while its setup.py is being fixed for Pip 20+ ( leovp/steamfiles#19 )
WinterPhoenix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here: pypa/pip#7645
Also, using internals to parse requirements isn't recommended by the Pip team anyway, so we may want to consider doing it some other way.