Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py requirements parsing with Pip 20+ #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WinterPhoenix
Copy link

@WinterPhoenix WinterPhoenix commented Oct 26, 2020

Accidentally removed the old repo tied to this Pull Request, so I'm resubmitting.

Original PR here: #19

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.506% when pulling 18bb08d on WinterPhoenix:patch-1 into 3b03ec3 on leovp:master.

@sakshatshinde
Copy link

Has this not been merged yet?

@pgh268400
Copy link

pgh268400 commented Jan 15, 2024

I think this pr should be merged. In latest version of pip

The package is not installed properly because of the import statement below.

try: # for pip >= 10
from pip._internal.req import parse_requirements
from pip._internal.download import PipSession
except ImportError: # for pip <= 9.0.3
from pip.req import parse_requirements
from pip.download import PipSession

The package was installed properly only after manually downloading the library and manually applying the pr to setup.py.

However, after finishing installing the package, I encountered this error.

@sakshatshinde
Copy link

Any update? @leovp @NullSoldier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants