-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode updates #508
Comments
please, for the love of God do not implement the combo fix. one particularity of why the Linux version has always been a go-to for me is the absence of need to have to scroll my hand off to find parts when editing using the properties widget to do in-place parts switching. the popup combo is actually much handier than one would think. |
I like the small combo box popup better but I see the point of leaving it as is for now. I'll replace the part picker with a better dialog where people can actually search for parts instead of a combo box before changing the popup behavior. |
@leozide would you maybe integrate a small option to toggle combo behavior if you eventually change it? Maybe even as a hidden config parameter, just for the sake of flexibility? |
Part color outline does not show with current theme (in wireframe viewing mode) - dark scheme might need an update to refelct these contrasting changes - maybe we could also get a colors/outlines/selection dialog or option set to choose our own? see attached EDIT: I realize this may actually be related to background color selection, although we could benefit from some kind of unified and complete dark vs. normal theme. |
This update to stylesheet.qss fixes the following dark mode formatting:
Tooltip before:
![Screenshot - 05_10_2020 , 12_02_24](https://user-images.githubusercontent.com/13388970/95071931-b9034a00-070a-11eb-9c40-d001c864a673.png)
Tooltip after:
![Screenshot - 05_10_2020 , 12_07_49](https://user-images.githubusercontent.com/13388970/95071976-ca4c5680-070a-11eb-87b2-9bcd175d37a5.png)
Combo drop-down before:
![Screenshot - 05_10_2020 , 12_05_18](https://user-images.githubusercontent.com/13388970/95072100-fb2c8b80-070a-11eb-8979-06544347959e.png)
Combo drop-down after:
![Screenshot - 05_10_2020 , 12_07_26](https://user-images.githubusercontent.com/13388970/95072120-05e72080-070b-11eb-8ad6-c5e5b4997960.png)
Menu separator before:
![Screenshot - 05_10_2020 , 12_08_52](https://user-images.githubusercontent.com/13388970/95072156-10091f00-070b-11eb-8646-0ce3560d992c.png)
Menu separator after:
![Screenshot - 05_10_2020 , 12_09_29](https://user-images.githubusercontent.com/13388970/95072179-17c8c380-070b-11eb-86d5-fe3dbbce1e21.png)
Cheers,
The text was updated successfully, but these errors were encountered: