Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode updates #508

Open
trevorsandy opened this issue Oct 5, 2020 · 4 comments
Open

Dark mode updates #508

trevorsandy opened this issue Oct 5, 2020 · 4 comments

Comments

@trevorsandy
Copy link
Contributor

This update to stylesheet.qss fixes the following dark mode formatting:

/* tooltip color */
QToolTip {
    color: #3A3A3A; background-color: #E0E0F4; border: 0px;
}

/* combo drop-down size */
QComboBox {
    combobox-popup: 0;
}

/* menu separator */
QMenu::separator {
    height: 1px;
    background: #737373;
    margin-left: 10px;
    margin-right: 5px;
}

Tooltip before:
Screenshot - 05_10_2020 , 12_02_24

Tooltip after:
Screenshot - 05_10_2020 , 12_07_49

Combo drop-down before:
Screenshot - 05_10_2020 , 12_05_18

Combo drop-down after:
Screenshot - 05_10_2020 , 12_07_26

Menu separator before:
Screenshot - 05_10_2020 , 12_08_52

Menu separator after:
Screenshot - 05_10_2020 , 12_09_29

Cheers,

@nathaneltitane
Copy link

please, for the love of God do not implement the combo fix.

one particularity of why the Linux version has always been a go-to for me is the absence of need to have to scroll my hand off to find parts when editing using the properties widget to do in-place parts switching.

the popup combo is actually much handier than one would think.

@leozide
Copy link
Owner

leozide commented Oct 17, 2020

I like the small combo box popup better but I see the point of leaving it as is for now. I'll replace the part picker with a better dialog where people can actually search for parts instead of a combo box before changing the popup behavior.

@nathaneltitane
Copy link

nathaneltitane commented Oct 17, 2020

@leozide would you maybe integrate a small option to toggle combo behavior if you eventually change it? Maybe even as a hidden config parameter, just for the sake of flexibility?

@nathaneltitane
Copy link

nathaneltitane commented Dec 12, 2020

@leozide

Part color outline does not show with current theme (in wireframe viewing mode) - dark scheme might need an update to refelct these contrasting changes - maybe we could also get a colors/outlines/selection dialog or option set to choose our own?

see attached

Screenshot_20201212-175946_VNC Viewer
Screenshot_20201212-175953_VNC Viewer

EDIT:

I realize this may actually be related to background color selection, although we could benefit from some kind of unified and complete dark vs. normal theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants