Not all colors are visible in wireframe/dark mode

[nathaneltitane]

see attached:

versus:

[nathaneltitane]

@trevorsandy @leozide is this related to #508 ?

[trevorsandy]

I don't think so.

It looks like the default wireframe line colour (for solid colour pieces) is the same as the dark theme background colour so lines for non-trans pieces are not visible. If you change the background colour you will see the solid piece lines.

However, there is another anomaly in that conditional lines are not shown for the wireframe view so cylindrical pieces will only show a front and rear circle and surfaces without edge-lines will not be shown. As a result, models will appear incompletely rendered.

Cheers,

[nathaneltitane]

Any chance we can implement an option to change the outline color or does that depend on the parts color list implementation?

Is that currently managed by leocad?

[rsbx]

Likely comes from the colors file. If that's the case, you'd want to use an alternative colors file. Another option is to use a dark gray instead of black for you dark mode background.

…

On 2020-12-30 10:48, Nathanel Titane wrote: Any chance we can implement an option to change the outline color or does that depend on the parts color list implementation? Is that currently managed by leocad? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#582 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAECJNBKMF455N3KGBXSQ5TSXNDUXANCNFSM4VMTFAYQ>.

[trevorsandy]

I haven't looked at how Leo is deriving the wireframe line colour. He may be specifying it staticaly or using the edge colour from LDConfig.ldr.

In any case, it is certainly possible to manage the line colour so that it always contrasts with the background colour.

Cheers,

[leozide]

Colors come from LDConfig.ldr, you have to either edit it or change your background color.

[nathaneltitane]

Likely comes from the colors file. If that's the case, you'd want to use
an alternative colors file.

Another option is to use a dark gray instead of black for you dark mode
background.

On 2020-12-30 10:48, Nathanel Titane wrote:

Any chance we can implement an option to change the outline color or
does that depend on the parts color list implementation?

Is that currently managed by leocad?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#582 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAECJNBKMF455N3KGBXSQ5TSXNDUXANCNFSM4VMTFAYQ.

@rsbx it is a dark gray. You probably meant black for the both?

I like my interface uniform, keeps the focus on the editing.

[nathaneltitane]

I haven't looked at how Leo is deriving the wireframe line colour. He may be specifying it staticaly or using the edge colour from LDConfig.ldr.

In any case, it is certainly possible to manage the line colour so that it always contrasts with the background colour.

Cheers,

@trevorsandy would be cool if we could override ldconfig without manually changing it.

[rsbx]

No, I meant use a lighter color gray than the edge color for your background.

…

On 2020-12-30 11:21, Nathanel Titane wrote: Likely comes from the colors file. If that's the case, you'd want to use an alternative colors file. Another option is to use a dark gray instead of black for you dark mode background. On 2020-12-30 10:48, Nathanel Titane wrote: Any chance we can implement an option to change the outline color or does that depend on the parts color list implementation? Is that currently managed by leocad? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub #582 (comment) <#582 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAECJNBKMF455N3KGBXSQ5TSXNDUXANCNFSM4VMTFAYQ. @rsbx <https://github.com/rsbx> it is a dark gray. You probably meant black for the both? I like my interface uniform, keeps the focus on the editing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#582 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAECJNDRAF2J7U76SQC5WTDSXNHO5ANCNFSM4VMTFAYQ>.