Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: failing to correctly trigger the methods of the INavigationAware interface. #1177

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

textGamex
Copy link
Contributor

@textGamex textGamex commented Jul 27, 2024

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

When both the View and ViewModel inherit from the INavigationAware interface, only the OnNavigatedToAsync/OnNavigatedFromAsync methods of the View are triggered

Issue Number: #1169

What is the new behavior?

  • fix this bug.

Other information

The order in which the OnNavigatedToAsync/OnNavigatedFromAsync methods of View and ViewModel are called is not guaranteed

… interface.

when both the View and ViewModel inherit from the INavigationAware interface, only the OnNavigatedToAsync/OnNavigatedFromAsync methods of the View are triggered
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request navigation Changes to navigation related controls. dotnet release labels Jul 27, 2024
@pomianowski pomianowski merged commit d27947e into lepoco:main Aug 11, 2024
2 checks passed
@textGamex textGamex deleted the fix branch August 11, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet navigation Changes to navigation related controls. PR Pull request release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants