Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageControlDocumentation control #688

Merged

Conversation

IvanDmitriev1
Copy link
Collaborator

@IvanDmitriev1 IvanDmitriev1 commented Jun 30, 2023

Added new PageControlDocumentation control for page documentation.
Simplified every page xaml.
Deleted GalleryControlPresenter and ControlDocumentationSummary.

Added Navigated event to the NavigationView.

Before vs. after:
Untitled-1

Pull request

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

@cla-bot
Copy link

cla-bot bot commented Jun 30, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Jun 30, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Jun 30, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Jun 30, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @IvanDmitriev1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@IvanDmitriev1 IvanDmitriev1 marked this pull request as ready for review June 30, 2023 14:02
@pomianowski pomianowski merged commit 9cbb35b into lepoco:development Jul 1, 2023
2 checks passed
@IvanDmitriev1 IvanDmitriev1 deleted the New-documantation-control branch July 1, 2023 15:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants