Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing background removal #833

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

niels9001
Copy link
Collaborator

Pull request type

Addressing: #831

This was introduced in a #814, and was meant for updating the background when moving from HC to light/dark theme. As it breaks normal theme switching on W10, commenting this out for now. Moving from HC to light/dark is a minor edge case, and should not impact a lot of users. Relaunching the app should make any bugs go away.

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Nov 22, 2023
@niels9001 niels9001 changed the base branch from main to development November 22, 2023 13:29
@niels9001
Copy link
Collaborator Author

@pomianowski Would you mind, after this gets merged, to generate a new preview-10? That should completely unblock us from release PowerToys vNext :)!

@pomianowski
Copy link
Member

Hey @niels9001, I will try to release a version with .NET 8 support today

@pomianowski pomianowski merged commit e7b1625 into lepoco:development Nov 22, 2023
1 check passed
@niels9001 niels9001 deleted the niels9001/w10-themefix branch November 22, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants