Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple HighContrast themes support #814

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Multiple HighContrast themes support #814

merged 3 commits into from
Nov 13, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Nov 10, 2023 •
edited
Loading

This PR:

  • makes sure the right high contrast theme resource dictionary is loaded so that we can support all existing HC themes
  • makes sure the background of a window is a solid color when in HC mode.

ContrastWPfui

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@niels9001 niels9001 changed the title Niels9001/themefix Multiple HighContrast themes support Nov 10, 2023
@pomianowski
Copy link
Member

Hey @niels9001, thank you for your continued support for the project!

@pomianowski pomianowski merged commit 23c8773 into lepoco:development Nov 13, 2023
2 checks passed
@niels9001
Copy link
Collaborator Author

Hey @niels9001, thank you for your continued support for the project!

@pomianowski Happy to help :)! Is there a timeline for preview-9 that contains these fixes? Would love to test these out in production!

@pomianowski
Copy link
Member

@niels9001, it should be live on NuGet in 15 minutes

@niels9001
Copy link
Collaborator Author

@niels9001, it should be live on NuGet in 15 minutes

Thanks!!!

@niels9001 niels9001 mentioned this pull request Nov 22, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomianowski pomianowski pomianowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niels9001 @pomianowski