Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected graphicals in generated netlist #250

Closed
graahnul-grom opened this issue Sep 7, 2018 · 0 comments
Closed

Connected graphicals in generated netlist #250

graahnul-grom opened this issue Sep 7, 2018 · 0 comments
Milestone

Comments

@graahnul-grom
Copy link
Member

lepton-netlist doesn't ignore graphical components if they are connected to nets. It happens with some backends (not all), notably, with PCB and drc2.

Test schematic (attached):
netlist_graphicals

C1 should not appear in resulting netlist, but it is:

$ lepton-netlist -o - -g PCB netlist_graphicals.sch
GND R1-1 R3-2
netx C1-1 R1-2 R2-1
nety C1-2 R2-2 R3-1

lepton-netlist -o - -g drc2 netlist_graphicals.sch
Checking non-numbered parts...
Checking duplicated references...
Checking NoConnection nets for connections...
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
NOTE: Found pins without the 'pintype' attribute: C1:1 C1:2
Checking type of pins connected to a net...
Checking unconnected pins...
Checking slots...
Checking duplicated slots...
Checking unused slots...

If you disconnect C1 from netx and nety nets, lepton-netlist will generate a correct netlist.

netlist_graphicals.zip

@vzh vzh closed this as completed in #251 Sep 9, 2018
vzh added a commit to vzh/lepton-eda that referenced this issue Sep 9, 2018
The lepton issue lepton-eda#250 revealed that there was no test in the
lepton-netlist test suite for filtering components having the
"graphical=" attribute attached. This patch adds the test based on
the schematic by dmn provided in the issue.
vzh added a commit that referenced this issue Sep 10, 2018
The lepton issue #250 revealed that there was no test in the
lepton-netlist test suite for filtering components having the
"graphical=" attribute attached. This patch adds the test based on
the schematic by dmn provided in the issue.
@vzh vzh added this to the 1.9.6 milestone Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants