feat: use cdn url for static assets (#2281)

[zoomiti]

Closes #2281

[zoomiti]

me when i forgor to run cargo fmt

[gbj]

Thanks, this looks great!

@zoomiti I recommended a small change in the comment above. The CI issues here are unrelated and I need to fix things up on main.

@CodingFlow could you let us know if this solves it for your use case? The approach here would be something like

CDN_PKG_PATH=https://my-cool-cdn.com/my-leptos-app/pkg cargo leptos build

i.e., including the CDN_PKG_PATH at compile time.

[zoomiti]

Wow it looks like CI is so big the container ran out of diskspace, at least for server_fn
Not sure what happened for select_stable

[CodingFlow]

Thanks, this looks great!

@zoomiti I recommended a small change in the comment above. The CI issues here are unrelated and I need to fix things up on main.

@CodingFlow could you let us know if this solves it for your use case? The approach here would be something like

CDN_PKG_PATH=https://my-cool-cdn.com/my-leptos-app/pkg cargo leptos build

i.e., including the CDN_PKG_PATH at compile time.

Yes, that looks it should do it for me. 👍

[gbj]

Thanks very much!

[rakshith-ravi]

Okay. Small regression. What happens when my leptos app is not hosted at /? Let's say it's hosted at /ui?

The current code assumes / as the root regardless of what's given in the cargo.toml. Isn't this something we should fix?

[zoomiti]

The current code doesn't change any routing. All it does is make it so that static assets can be hosted on a CDN instead of on disk.

[gbj]

@rakshith-ravi I don't think this changes anything — before the PR, the integration assumed the pkg directory is relative to /, always. Now, the integration assumes the pkg directory is relative to /, unless you specify a build-time env variable CDN_PKG_PATH.

I might be wrong, in which case if you open an issue with a reproduction of problem I'll look at it.

[rakshith-ravi]

before the PR, the integration assumed the pkg directory is relative to /, always

Ahh, got it. Then we shouldn't have an issue regression