Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meilisearch_searchbar example #2305

Closed
wants to merge 10 commits into from
Closed

Conversation

sjud
Copy link
Contributor

@sjud sjud commented Feb 14, 2024

This example shows how to use a meilisearch server to provide a good search experience out of the box and with only a couple of basic parts.

@sjud
Copy link
Contributor Author

sjud commented Feb 18, 2024

Nobody fix this for me, I can do it!!

th-2446648034

@sjud
Copy link
Contributor Author

sjud commented Feb 20, 2024

Ok I give up. How do I get this to pass the CI check?

Run cd examples/meilisearch_searchbar
[cargo-make] INFO - cargo make 0.37.9
[cargo-make] INFO - Calling cargo metadata to extract project info
[cargo-make] INFO - Cargo metadata done
[cargo-make] INFO - Project: meilisearch_searchbar
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: ci
[cargo-make] INFO - Profile: github-actions
[cargo-make] ERROR - Task ci not found
[cargo-make] WARN - Build Failed.

@gbj
Copy link
Collaborator

gbj commented Feb 27, 2024

(Silly question but does it make a difference if you rename makefile.toml to Makefile.toml?)

I just left a similar comment on #2290: I wonder if we should start collecting interesting examples of how to do things somewhere else, as the examples directory in the repo is starting to become a little overwhelming. Adding more examples also slowly adds to maintenance burden as I end up updating them long term.

I've thought of splitting examples into something like examples/basic and examples/projects, and grouping the more complex examples under the latter. Any thoughts?

@sjud
Copy link
Contributor Author

sjud commented Feb 27, 2024

(Silly question but does it make a difference if you rename makefile.toml to Makefile.toml?)

I just left a similar comment on #2290: I wonder if we should start collecting interesting examples of how to do things somewhere else, as the examples directory in the repo is starting to become a little overwhelming. Adding more examples also slowly adds to maintenance burden as I end up updating them long term.

I've thought of splitting examples into something like examples/basic and examples/projects, and grouping the more complex examples under the latter. Any thoughts?

I like that idea.
examples/basic (or core) could demonstrate core functionality of the library and be something that the maintainers or broader team is willing to keep up to date with the quick velocity of the project, it would function as an extension of the docs/book.

And example/projects (or extra) could be an extension of awesome Leptos where people show off integrations, quirky little things, neat usages of Leptos. There was recently a Leptos camera that was posted to showcase which I think would be a great fit. And then this directory would not necessarily be up to date but still be useful to show how certain things could be done.

And awesome Leptos could be real world use cases, actual open source projects etc.

I think right now there's a gap between showing off big projects and showing off core functionality. @diversable had floated a leptos magazine type of blog but having this extra examples directory could provide source material and a good launching point for a more expansive look into all the neat little usecases/integrations for Leptos.

Let me know what you think about my thoughts about your thoughts, thanks!! :)

@gbj
Copy link
Collaborator

gbj commented Apr 17, 2024

Superseded by #2500.

@gbj gbj closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants