Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile error when using comment and doctype tags within the view! macro #2355

Closed
wants to merge 3 commits into from

Commits on Feb 22, 2024

  1. Qualify all uses of proc_macro_error::abort!

    Just for consistency. `proc_macro_error::emit_error` is always called in
    the qualified form, but `proc_macro_error::abort!` was sometimes called
    in the non-qualified form, which was made possible by
    `#[macro_use] external crate proc_macro_error`.
    thinety committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    ffa0c09 View commit details
    Browse the repository at this point in the history
  2. Add compile error when comment and doctype tags are used within view!

    Currently, these tags are not displayed in the rendered view. Instead
    of silently doing so, this change introduces a compile error with a
    helpful message.
    thinety committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b44863b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Change compile-time errors for warnings

    Emit compile-time warnings instead of errors when using doctype and
    comment tags within `view!` macro.
    thinety committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5c3867e View commit details
    Browse the repository at this point in the history