filetype of Image Captcha can be specified #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
2 similar comments
|
I've already used png as default value. Is it time to merge my pull request? Thank you~ |
|
@Silence-WWT Hi, it is merged into 4e8d6c7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although JPEG compression is a loss compression and PNG is non-lossy, the loss of image captcha quality is bearable. The size of JPEG image captcha after default compression by PIL can be much more smaller than PNG. So I suppose add a parameter 'format' which equals to 'jpeg' by default in the function generate & write of class _Captcha can be better. (If someone still want to use PNG or other filetypes……)