Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support transfer customer service #10

Merged
merged 1 commit into from
Dec 30, 2014
Merged

Conversation

killpanda
Copy link

支持多客服系统,可以转发信息给多个客服或者指定客服。

@lepture
Copy link
Owner

lepture commented Dec 30, 2014

ping @VeryCB

@tonyseek
Copy link
Collaborator

LGTM.

But could we give a better name to the argument "to_kf"? We don't have to follow the language-mixed naming of Tencent. >﹏<

@GuoJing
Copy link

GuoJing commented Dec 30, 2014

Good, i agree, just change the name to_kf.

@killpanda
Copy link
Author

How about service_account? @tonyseek @GuoJing

@killpanda killpanda changed the title support transfer service support transfer customer service Dec 30, 2014
@tonyseek
Copy link
Collaborator

I think it is okay.

@GuoJing
Copy link

GuoJing commented Dec 30, 2014

Superb, love you!

@killpanda
Copy link
Author

@tonyseek @GuoJing changed

@VeryCB
Copy link
Collaborator

VeryCB commented Dec 30, 2014

LGTM

@@ -199,6 +200,27 @@ def reply(self, username, type='text', sender=None, **kwargs):

return None

def transfer_customer_service(self, username, sender=None,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it in the reply method.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

lepture added a commit that referenced this pull request Dec 30, 2014
support transfer customer service
@lepture lepture merged commit 9687026 into lepture:master Dec 30, 2014
@killpanda
Copy link
Author

有时间发个版本出来吧 thx a lot!

@lepture
Copy link
Owner

lepture commented Dec 30, 2014

@VeryCB 可以发

@VeryCB
Copy link
Collaborator

VeryCB commented Dec 30, 2014

我来发一版

@VeryCB
Copy link
Collaborator

VeryCB commented Dec 30, 2014

0.4.0 is released

@GuoJing
Copy link

GuoJing commented Dec 30, 2014

@VeryCB Thank you man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants