Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pagination support on S3Bucket.listdir #3

Closed
wants to merge 4 commits into from

Conversation

kevinclark
Copy link
Contributor

We've got folders with 1000+ things. This change makes it so we can get to them without changing code.

@lericson
Copy link
Owner

I'm all for the idea behind this change, I should note - I would love to have a listdir() that spans multiple requests. I just don't think it's a good idea to mutilate an existing method so it suites other needs.

@kevinclark
Copy link
Contributor Author

Doh, just saw your other reply. Got it. Will consider an alternative that doesn't modify already established methods.

Rips out autolooping in listdir in favor of a method on the outside.
@kevinclark
Copy link
Contributor Author

Ok, how's this?

@lericson
Copy link
Owner

lericson commented Feb 4, 2011

Sorry for not getting back to you; I've been ill and am catching up with a backlog of things I need to do, so I hope I have time to make a decision here as soon as possible.

@kevinclark
Copy link
Contributor Author

No problem. I'm happy to continue tweaking if you think it needs it. For now, we've just been running out of our own branch.

@lericson
Copy link
Owner

lericson commented Feb 9, 2011

Boy did you ever get me confused with having a different GitHub account from the one hosting the repository. :-D

Going to try and merge this now, stop by in #sendapatch on freenode if you want some IM action going.

@lericson
Copy link
Owner

lericson commented Feb 9, 2011

Merge S3 listing changes from Greplin

Closed by 19a078b, and also includes the secure argument to S3Bucket.

paxan pushed a commit to paxan/simples3 that referenced this pull request May 4, 2012
Fixes lericson#3, and also includes the `secure` argument to S3Bucket.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants