Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from normalize-git-info to hosted-git-info. #268

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Mar 13, 2020

hosted-git-info is used by the npm command line client to parse repository URLs in package.jsons. It seems to have largely replaced normalize-git-info (hosted-git-info has ~ 14m downloads weekly, vs normalized-git-info which has ~ 90k downloads weekly).

Migrating also removes the manual RegExp from lerna-changelog, which seems nice. 馃槃

`hosted-git-info` is used by the `npm` command line client to parse
repository URLs in `package.json`s. It seems to have largely replaced
`normalize-git-info` (`hosted-git-info` has ~ 14m downloads weekly, vs
`normalized-git-info` which has ~ 90k downloads weekly).

Migrating also removes the manual RegExp from `lerna-changelog`, which
seems nice. 馃槃
Copy link
Contributor

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thank you!

@Turbo87 Turbo87 merged commit 06a55fe into lerna:master Mar 13, 2020
@rwjblue rwjblue deleted the use-hosted-git-info branch March 14, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants