fix(package): Chain self from serialize() method for parity with refr…

…esh()
lerna · Dec 20, 2018 · 98c812c · 98c812c
1 parent 284aa47
commit 98c812c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/core/package/__tests__/core-package.test.js b/core/package/__tests__/core-package.test.js
@@ -211,9 +211,9 @@ describe("Package", () => {
       loadJsonFile.mockImplementationOnce(() => Promise.resolve({ name: "ignored", mutated: true }));
 
       const pkg = factory({ name: "refresh" });
+      const result = await pkg.refresh();
 
-      await pkg.refresh();
-
+      expect(result).toBe(pkg);
       // a package's name never changes
       expect(pkg.name).toBe("refresh");
       expect(pkg.get("mutated")).toBe(true);
@@ -226,9 +226,9 @@ describe("Package", () => {
       writePkg.mockImplementation(() => Promise.resolve());
 
       const pkg = factory({ name: "serialize-me" });
+      const result = await pkg.set("woo", "hoo").serialize();
 
-      await pkg.set("woo", "hoo").serialize();
-
+      expect(result).toBe(pkg);
       expect(writePkg).toHaveBeenLastCalledWith(
         pkg.manifestLocation,
         expect.objectContaining({

diff --git a/core/package/index.js b/core/package/index.js
@@ -156,7 +156,7 @@ class Package {
    * @returns {Promise} resolves when write finished
    */
   serialize() {
-    return writePkg(this.manifestLocation, this[PKG]);
+    return writePkg(this.manifestLocation, this[PKG]).then(() => this);
   }
 
   /**