-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Lerna swallows exit code when NODE_ENV is test #406
Comments
We should change that to |
I'm not sure they're mutually exclusive. Presumably you still want to hide progress bars – unless you want to modify the other checks for |
Ah good point, we can just move it to a method and mock it in the tests |
After looking at the code, I wrongfully assumed that |
* add lint dependencies to packages, add lint to storybook * Add node_modules cache directories * Add root level node_modules to cache * Set NODE_ENV to ci to fix lerna suppressing error messages (see lerna/lerna#406) * Update node to the latest LTS release
Looks like In response to @taion's comment:
If the checks you're referring to are the ones I mentioned above, it seems reasonable (and preferable) to modify them – would you agree? If so I'd be happy to put in a PR implementing @thejameskyle's first suggestion of changing it to |
@ryb73 Yeah, that sounds worthwhile. Thanks! |
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Due to this code: https://github.com/lerna/lerna/blob/v2.0.0-beta.30/src/Command.js#L156-L158
Lerna commands won't pass through their exit codes when
NODE_ENV
istest
.CircleCI automatically sets
NODE_ENV
totest
for builds that use Node, so if you do something likelerna run test
, your build won't fail when your tests fail.The text was updated successfully, but these errors were encountered: