Change testing NODE_ENV to "lerna-test" (Fixes #406)

[ryb73]

fixes #406

Previously, when running Lerna with NODE_ENV set to "test", it would output nothing to stdout and always exit with a code of 0. Now the output and exit code will not be suppressed.

[gigabo]

Thanks @ryb73 this LGTM.

@taion does this work for you?

[taion]

the progress bar does look a bit wonky in CI logs. wonder if there's a better flag here... maybe env.CONTINUOUS_INTEGRATION or something

[gigabo]

Yeah, wonky whenever we're not running interactively.

Maybe a better check here would be whether we're connected to a tty?

if (process.stdout.isTTY) {
    ...
}

[taion]

it's irrelevant to this PR anyway, just a quirk i noticed after i unset NODE_ENV on circle. probably best to add a FIXME and sort this out later, since it's not that important

[gigabo]

Filed #447. Thanks for looking at this @taion.

[petercasinelli]

Hey, thanks for catching this! Is there any way you can release this sooner rather than later? It's a blocker for people relying on tests to fail a build. Right now, a build can pass even if the tests fail because the exit codes are not propagated. I'm experiencing this right now with CircleCI.

I considered pulling in the master branch in, but in order to use it, you'll need to run npm i and install Lerna globally from the cloned repo. This is unrealistic for continuous integration because you'd need to clone for every build.

[taion]

This ought not be a blocker with Circle. Just do

dependencies:
  override:
    # Circle sets NODE_ENV to test by default, which messes with both Lerna and
    # babel-plugin-dev-expression.
    - unset NODE_ENV
    - npm i

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.