-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] README.md is not published to npm #64
Comments
The README where? Individual packages should have their own README, the primary one at the root of the repo will not be published anywhere. |
Weird... we're literally just |
Maybe something to do with the package not living at the repo root? Seems more likely to be an |
Yes, I do have readmes... When I was trying to find a problem I noticed that you just run existing npm... have no idea what can be a problem here. Only aware of this issue in outdated version of npm. |
@gigabo But it works fine when I run |
I seem to be running into the same issue. I definitely have a new README, but the changes aren't showing up on NPM. |
(by NPM, I mean https://www.npmjs.com/) |
I have a hypothesis that the way lerna messes with dist-tags isn't triggering npm's normal website refresh job. I've opened a support ticket with npm, inc to investigate and will report back here if I hear anything. |
@ianwremmel thank you very much, I still suffer from this issue. |
This bug is hard to debug as I've had no problems with README's (https://www.npmjs.com/package/cf-component-modal) |
I heard back from npm. It is indeed a result of the dist-tags technique used by lerna. npm has an open issue: https://github.com/npm/newww/issues/389#issuecomment-188428605 |
Ok, it's a hack, but a I got some help from npm and there's at least a way we can trick npm into rebuilding the readme. First, add "-readmehack" to the end of the package version in package.json, then: npm publish
npm dist-tag add ciscospark@0.6.3 latest
npm unpublish ciscospark@0.6.3-readmehack |
I don't really want to put a hack like that into lerna. The publishing process is already very complex and that adds a lot of complexity |
Agreed, I'm not suggesting that gets hacked in, but it at least helps those with the problem until npm fixes the bug. |
In my case, I only actually have one readme I need to update, so I can put that in my publish script pretty trivially. |
I'm having the same issue... |
Locking this. I want an update just as much as everyone, but please just follow the actual issue on npm: Edit (@gigabo): Looks like the npm ticket moved here: https://github.com/npm/registry/issues/42 |
Alright!!! An update to this issue: it should be fixed (via npm side)!So I just published 6.22.0 yesterday and was thinking about publishing to the Turns out @bcoe had been working on fixing this issue, so it looks like it's all good for us on this one?
We haven't published a new babel version in a month (>30 days) Example with https://www.npmjs.com/package/babel-core https://github.com/babel/babel/pull/5101/files (5 days ago) EDIT: 😍😍😍😍😍😍 |
Awesome! Finally! 🎉 |
Awesome! Thanks @bcoe! The emoji don't exist to express my excitement! |
Thanks! Giving credit where credit is due, the whole backend team at npm has been working on infrastructure this makes solving problems like this much easier (we've been rolling out a database that was @chrisdickinson's mad-science idea). I'm really excited to make the tag workflow elegant, for the community and for the benefit of my own OSS projects. |
Have Lerna update all versions and dependencies where required in `package.json` files without actually publishing the changes to NPM. This is useful for publishing manually, which is necessary to do periodically to get README updates to show up on npmjs.com (until https://github.com/npm/newww/issues/389 is resolved). This is a workaround for lerna#64. This was proposed in lerna#127.
I'm confused. It sounds like @hzoo is saying that the npm website now picks up the README from whatever's on master in GitHub repository. I have not experienced this in my own projects, looking though issues for the npm website and registry for whatever changes were alluded to above, I see comments like this which make it seem like that is not the case at all. @bcoe would you be able to shed light on the behavior we should expect, or point to any docs or at least the changes above? Thanks! |
@tomwayson Hey 👋 So, rather than always pointing to the last published README file, we now point to whatever README is pointed to by the |
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When I try
lerna publish
- npm registry doesn't display readme, however when I use npm publish - it does.The text was updated successfully, but these errors were encountered: