Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package-graph): Flatten cycles to avoid skipping packages #2185

Merged
merged 22 commits into from
Jul 18, 2019
Merged

fix(package-graph): Flatten cycles to avoid skipping packages #2185

merged 22 commits into from
Jul 18, 2019

Commits on Jul 18, 2019

  1. Add wrong test

    @nicolo-ribaudo
    nicolo-ribaudo committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    6faa234 View commit details
    Browse the repository at this point in the history

  2. Fix partitionCycles with multiple dependencies

    @nicolo-ribaudo
    nicolo-ribaudo committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    284b9b8 View commit details
    Browse the repository at this point in the history

  3. Add more fixtures

    @nicolo-ribaudo
    nicolo-ribaudo committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    a918a22 View commit details
    Browse the repository at this point in the history

  4. Update cycles detection logic

    @nicolo-ribaudo
    nicolo-ribaudo committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    d405c84 View commit details
    Browse the repository at this point in the history

  5. Tests

    @nicolo-ribaudo
    nicolo-ribaudo committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    14ab7a8 View commit details
    Browse the repository at this point in the history

  6. [lint] Use fn declarations

    @nicolo-ribaudo
    nicolo-ribaudo committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    031ecf3 View commit details
    Browse the repository at this point in the history

  7. Revert wrong change in fixture lerna.json

    @nicolo-ribaudo
    nicolo-ribaudo committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    9c5d045 View commit details
    Browse the repository at this point in the history

  8. test: cover PackageGraphNode.toString()

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    8461839 View commit details
    Browse the repository at this point in the history

  9. chore: package.json files should be 2-space indented, with trailing s… 

    …pace
    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    9072dea View commit details
    Browse the repository at this point in the history

  10. Remove externalDependencies map from PackageGraphCollapsedNode, it's … 

    …unnecessary
    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    bf6ee90 View commit details
    Browse the repository at this point in the history

  11. Refactor hasPackageDeep() to return early instead of iterating over _… 

    …every_ member
    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    f8c531a View commit details
    Browse the repository at this point in the history

  12. un-nest version-command tests

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    d06424a View commit details
    Browse the repository at this point in the history

  13. test: Always run order-sensitive toposort tests with concurrency of 1… 

    …, avoid environmental variability
    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    807ea59 View commit details
    Browse the repository at this point in the history

  14. test: Update expected order of toposort calls

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    11f9ff4 View commit details
    Browse the repository at this point in the history

  15. fix arrows in graph models

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    0fd8bec View commit details
    Browse the repository at this point in the history

  16. cleanup query-graph

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    176c0cb View commit details
    Browse the repository at this point in the history

  17. Rename PackageGraphCollapsedNode -> CyclicPackageGraphNode

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    eeab59d View commit details
    Browse the repository at this point in the history

  18. cleanup cyclic methods

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    35a2b49 View commit details
    Browse the repository at this point in the history

  19. Add .unlink() instance method to CyclicPackageGraphNode

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    28727a3 View commit details
    Browse the repository at this point in the history

  20. forEach -> for-of

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    df7021c View commit details
    Browse the repository at this point in the history

  21. rename methods and parameters for clarity

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    794af07 View commit details
    Browse the repository at this point in the history

  22. s/add/insert/, former method was too Set-like

    @evocateur
    evocateur committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    1006a36 View commit details
    Browse the repository at this point in the history