-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package-graph): Flatten cycles to avoid skipping packages #2185
Changes from all commits
6faa234
284b9b8
a918a22
d405c84
14ab7a8
031ecf3
9c5d045
8461839
9072dea
bf6ee90
f8c531a
d06424a
807ea59
11f9ff4
0fd8bec
176c0cb
eeab59d
35a2b49
28727a3
df7021c
794af07
1006a36
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
+---+ | ||
| A | | ||
+---+ | ||
| | ||
v | ||
+---+ +---+ +---+ | ||
| E | --> | B | <-- | G | | ||
+---+ +---+ +---+ | ||
^ | ^ | ||
| v | | ||
+---+ +---+ +---+ | ||
| D | <-- | C | --> | F | | ||
+---+ +---+ +---+ | ||
|
||
Cycles: | ||
B -> C -> D -> E -> B | ||
B -> C -> F -> G -> B | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"version": "1.0.0" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"name": "cycle-intersection" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "a", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"b": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "b", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"c": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"name": "c", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"d": "^1.0.0", | ||
"f": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "d", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"e": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "e", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"b": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "f", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"g": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "g", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"b": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
https://github.com/lerna/lerna/issues/2107#issuecomment-511987691 | ||
|
||
+---+ | ||
/----> | B | | ||
| +---+ | ||
| | ||
+---+ +---+ -----\ | ||
| A | --> | C | | | ||
+---+ +---+ <-\ | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: C and D's dependency lines should only point one direction each, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch, I've fixed this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! |
||
| | | | ||
| +---+ --/ | | ||
\----> | D | | | ||
+---+ <----/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"version": "1.0.0" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"name": "cycle-parent" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"name": "a", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"b": "^1.0.0", | ||
"c": "^1.0.0", | ||
"d": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"name": "b", | ||
"version": "1.0.0" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "c", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"d": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "d", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"c": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
+---+ +---+ | ||
| A | --> | B | <----\ | ||
+---+ +---+ | | ||
| | | | ||
v v | | ||
+---+ +---+ +---+ | ||
| H | | C | --> | D | | ||
+---+ +---+ +---+ | ||
| | | ||
v | | ||
+---+ | | ||
| E | <----\ | | ||
+---+ | | | ||
| | | | ||
v | | | ||
+---+ +---+ | | ||
| F | --> | G | <----/ | ||
+---+ +---+ | ||
|
||
Cycles: | ||
B -> C -> D -> B | ||
E -> F -> G -> E |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"version": "1.0.0" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"name": "cycle-separate" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"name": "a", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"b": "^1.0.0", | ||
"h": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "b", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"c": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "c", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"d": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"name": "d", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"b": "^1.0.0", | ||
"g": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "e", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"f": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "f", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"g": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "g", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"e": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "h", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"e": "^1.0.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
|
||
+------------------+ +---------+ -----\ | ||
| cycle-extraneous | --> | cycle-1 | | | ||
+------------------+ +---------+ <-\ | | ||
| | | ||
+---------+ --/ | | ||
| cycle-2 | | | ||
+---------+ <----/ | ||
|
||
+--------+ | ||
+-------+ --> | dag-2a | ---> +-------+ | ||
| dag-3 | +--------+ | dag-1 | | ||
+-------+ ------------------> +-------+ | ||
^ | ||
+--------+ | | ||
| dag-2b | --/ | ||
+--------+ | ||
|
||
+------------+ | ||
| standalone | | ||
+------------+ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"name": "independent" | ||
"name": "toposort" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the graphs!