Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(readme): Add note about fixed mode w/major version zero #2488

Merged
merged 1 commit into from
May 24, 2020

Conversation

0livare
Copy link
Contributor

@0livare 0livare commented Mar 10, 2020

Description

Add a note to the README about the lerna publish functionality when using a version number where the major revision is 0.

This fixes #2487

I'm not sure if this note describes what "should" happen, but it accurately
describes the current functionality.

Motivation and Context

The current Fixed/Locked mode documentation is not accurate when using a major version 0. This ammendment now makes the documentation accurate for both zero and non-zero major version revisions.

How Has This Been Tested?

This cannot be tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I'm not sure if this note describes what "should" happen, but it accurately
describes the current functionality.
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@evocateur evocateur merged commit 91d9d3e into lerna:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lerna updates all packages with every publish
2 participants