-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(publish): disable legacy verifyAccess
behavior by default
#3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahslaj
changed the title
feat: Improve error message when encountering a npm automation token
feat: default Jul 18, 2022
verifyAccess
to false for publish
fahslaj
force-pushed
the
publish-with-automation-token
branch
from
July 19, 2022 14:23
512536f
to
53f7c68
Compare
fahslaj
force-pushed
the
publish-with-automation-token
branch
from
July 22, 2022 04:01
53f7c68
to
cf79b9d
Compare
JamesHenry
reviewed
Jul 22, 2022
JamesHenry
reviewed
Jul 22, 2022
JamesHenry
reviewed
Jul 22, 2022
JamesHenry
reviewed
Jul 22, 2022
JamesHenry
approved these changes
Jul 22, 2022
JamesHenry
changed the title
feat: default
feat(publish): disable legacy Jul 22, 2022
verifyAccess
to false for publish
verifyAccess
behavior by default
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default
verifyAccess
to false forpublish
. Improve error message when encountering a npm automation token with verifyAccess=true.Description
Lerna will no longer try to verify the user's access (to the npm packages they are publishing) by default during
lerna publish
. Setting the verifyAccess option will still perform the verification as before. This also removes the need to ever use--no-verify-access
, since that is now the default behavior.Motivation and Context
This is important because the standard for authentication to npm in a CI/CD pipeline is using a npm automation token. These tokens do not support the
verifyAccess
option, due to the automation token's lack of read permissions. This PR also adds a more detailed error for the user when this case is encountered.See #2788 for discussion on lerna & npm automation tokens.
How Has This Been Tested?
I manually tested publishing a new lerna repo with a npm automation token and observed the behavior, both with verifyAccess=true and verifyAccess=false. I also performed this same test using a npm "publish" token. Unit tests have been added to cover the new behavior and the changed default behavior.
Types of changes
Checklist: