Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] Publish command is broken for 2.0.0-beta.33 #537

Merged
merged 1 commit into from
Jan 26, 2017
Merged

[CRITICAL] Publish command is broken for 2.0.0-beta.33 #537

merged 1 commit into from
Jan 26, 2017

Conversation

diogofcunha
Copy link
Contributor

Fixes this reported bug that is not allowing people using 2.0.0-beta.33 to publish packages.

Config flags shouldn't be undefined for publish.

@diogofcunha
Copy link
Contributor Author

@hzoo can we get this reviewed and if possible merged and published?
It is a blocker for us and I guess for many others.

Cheers.

@gigabo
Copy link
Contributor

gigabo commented Jan 26, 2017

Thanks @diogofcunha!

@diogofcunha
Copy link
Contributor Author

I am the one that needs to thank you for this amazing tool, saved us a lot of work..

If you want you can check our implementation in here https://github.com/adazzle/react-data-grid.

@gigabo
Copy link
Contributor

gigabo commented Jan 26, 2017

Looks cool! You should add yourselves to the "Who's using Lerna?" section of the website.

@gigabo gigabo merged commit e6e0c43 into lerna:master Jan 26, 2017
@gigabo gigabo added the bug label Jan 26, 2017
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants