Consider mutators on __isset of Attributes

leroy-merlin-br · Sep 20, 2017 · 7548292 · 7548292
1 parent a43eee2
commit 7548292
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/Mongolid/Model/Attributes.php b/src/Mongolid/Model/Attributes.php
@@ -212,7 +212,7 @@ public function __set($key, $value)
      */
     public function __isset($key)
     {
-        return isset($this->attributes[$key]);
+        return !is_null($this->{$key});
     }
 
     /**

diff --git a/tests/Mongolid/Model/AttributesTest.php b/tests/Mongolid/Model/AttributesTest.php
@@ -81,6 +81,26 @@ public function testShouldCheckIfAttributeIsSet()
         $this->assertFalse(isset($model->nonexistant));
     }
 
+    public function testShouldCheckIfMutatedAttributeIsSet()
+    {
+        // Arrange
+        $model = new class() {
+            use Attributes;
+
+            public function getNameAttribute()
+            {
+                return 'John';
+            }
+        };
+
+        /* Enable mutator methods */
+        $model->mutable = true;
+
+        // Assert
+        $this->assertTrue(isset($model->name));
+        $this->assertFalse(isset($model->nonexistant));
+    }
+
     public function testShouldUnsetAttributes()
     {
         // Arrange