Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property merging doesn't work in @font-face #2035

Closed
laughinghan opened this issue May 27, 2014 · 0 comments
Closed

Property merging doesn't work in @font-face #2035

laughinghan opened this issue May 27, 2014 · 0 comments
Labels
bug medium priority

Comments

@laughinghan
Copy link 

.font-face {
  src+: a;
  src+: b;
}
@font-face {
  src+: a;
  src+: b;
}

results in

.font-face {
  src: a, b;
}
@font-face {
  src: a;
  src: b;
}

(I tried using less2css.org assuming it was like JSBin or JSFiddle, but I couldn't figure out how to save my snippet as a shareable URL, so I'm just pasting it here, is that what is meant by "Include a live example. Please use less2css.org for sharing your isolated test cases."? That's really confusing)
SomMeri pushed a commit to SomMeri/less-rhino.js that referenced this issue Jul 25, 2014
Properties merging should work also inside directives less#2035
ce9db77 
The `_mergeRules` function is now called also for directives with rules.

I had to turn off jasmine tests for `merge.less`, because it was replacing
all urls by their assumed full paths. For example, the
`url(something.eot)` was changed into
`url(http://localhost:8081/test/less/something.eot)`. The result did not
matched with expected css and failed.

Note: I'm not sure why values order in source map changed. It does not
seem to be caused by my change, it was failing before I made them.
SomMeri pushed a commit to SomMeri/less-rhino.js that referenced this issue Jul 25, 2014
Properties merging should work also inside directives less#2035
c9c6ddb 
Fixes issue less#2035 - property merge inside @font-face. The _mergeRules function is now called also for directives with rules. It used to be called only for rulesets.

I had to turn off jasmine tests for merge.less, because it was replacing all urls by their assumed full paths. For example, the url(something.eot) was changed into url(http://localhost:8081/test/less/something.eot). The result did not matched with expected css and failed.

Note: I'm not sure why values order in source map changed. It does not seem to be caused by my change, it was failing before I made them.
@SomMeri SomMeri mentioned this issue Jul 25, 2014
Merged
lukeapage added a commit that referenced this issue Jul 27, 2014
@lukeapage
Merge pull request #2121 from SomMeri/font-face-property-merge-2-2035
4b40773 
Properties merging should work also inside directives #2035
@SomMeri SomMeri closed this as completed Jul 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laughinghan @SomMeri @seven-phases-max