Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to insert uppercase color names #1803

Merged
merged 1 commit into from
Jan 14, 2014
Merged

ability to insert uppercase color names #1803

merged 1 commit into from
Jan 14, 2014

Conversation

wareczek
Copy link
Contributor

No description provided.

@deviprsd
Copy link
Contributor

In browser the uppercase are automatically converted to lowercase, there won't be any difference between #FFFFFF and #ffffff

@wareczek
Copy link
Contributor Author

If you using less in JS code try to do that:

less.tree.Color.fromKeyword('White')

or that:

less.tree.Color.fromKeyword('RED')

You'll get null as result. Less should be sensitive for that.

@lukeapage
Copy link
Member

If its valid css (RED) we should do it.

@wareczek
Copy link
Contributor Author

http://www.w3.org/TR/css3-color/#html4

The color names are case-insensitive.

@lukeapage
Copy link
Member

okay, I'm sold.

lukeapage added a commit that referenced this pull request Jan 14, 2014
ability to insert uppercase color names
@lukeapage lukeapage merged commit 669701f into less:master Jan 14, 2014
@wareczek wareczek deleted the patch-1 branch January 14, 2014 21:44
@seven-phases-max
Copy link
Member

Btw., this is quite breaking change, it will break a code like:

@name: Aqua;

@{name} {
    /* ... */
}

I'd suggest to merge #1604 then (I've just added case-insensitivity there) since it becomes to be less breaking than this one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants