rhino version not up to date (#1405) #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luation (unify node/rhino error message)
…fic test only (use for example: -Ptest=urls)
Conflicts: build/build.yml
version handling of slashes.
…rive letter (c:\). Fixed in gradle.
1. Build the latest version of the rhino less version 2. Use the latest version to test against Also update Grunt build to have a build rhino task
Fix for issue #3: Tests should automatically take latest rhino file
Fix for some tests that were failing on my Mac
This patch adds Support Map Tests to the rhino test suite. It makes the following changes: 1. Fix typo in the Gruntfile.js for the sourcemap-test 2. Update Gradle build to always build the less-rhino-<version>.js before running the tests 3. Add a new testRhinoSourceMap and add it to the test list 4. Add a SourceMapRhinoTest that bootstraps SourceMap tests and then validates them after they run 5. Add hooks in RhinoTest to support custom bootstraping and validation 6. Add compiled version of source-map (version 0.1.31) because Rhino can't dynamically pull in dependencies 7. Add source-map to the Rhino build with a Header/Footer that wraps source-map as a less-friendly dependency 8. Update lib/less/rhino.js to properly handle (some) source-map options and add a new one (--source-map-output-map-file) that will output the source-map to a separate file (so we can validate our Rhino tests) 9. Remove unused callback in less-test.js
Add Support-Map Tests for Rhino
Conflicts: .gitattributes README.md test/index.js
Fix empty test
Don't lint source-map since its owned by another project
|
+1 |
| @@ -0,0 +1,1933 @@ | |||
| /* -*- Mode: js; js-indent-level: 2; -*- */ | |||
| /* | |||
| * Copyright 2011 Mozilla Foundation and contributors | |||
There was a problem hiding this comment.
I had a mental note to check the licenses were compatible before including, but reading through it, it looks like we will be okay.
There was a problem hiding this comment.
p.s. in future it would be nice to get this and put it in as part of the build process, but we can leave that for the future.
There was a problem hiding this comment.
Ok, I opened issue in less-rhino for it. So, it will not be forgotten when we come back to this next time.
lukeapage
added a commit
that referenced
this pull request
Jan 21, 2014
rhino version not up to date (#1405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request for #1405 adds rhino tests to less.js. Test framework is written in gradle. It calls grunt to build rhino version of less.js and then runs all less.js tests on it.
Testing rhino for the first time:
npm installgradlew testRhinoTesting rhino nth time:
gradlew testRhinoThere is room for improvement:
However, rewriting this would take a lot more time and it might be more effective to do it after #1732 refactoring.