Base64 encode source maps

[tim-smart]

This prevents some edge cases where encodeURIComponent fails to create a valid
source map.

This particular edge case was identified when trying to create source maps for
the lesshat mixin library.

[lukeapage]

did you forget to add ./encoder.js ? Or am I missing something?

[tim-smart]

@lukeapage Everything seems fine here: https://github.com/less/less.js/pull/2045/files#diff-bdfdddf2d3118d66d6b361ea5258c481R130

If you are referring to the failed travis build, that was caused by npm failing for some reason or another on Node 0.8.x.

[lukeapage]

Hi,

No, I'm not and that issue with node 0.8 is now fixed in master.

I may well be missing something, but where does "./encoder.js" come from? its using a relative path as if its a file we maintain in the less libs folder, but you didn't include it in your commit. If its a dependency it would need adding to the package file (but I can't find an encoder package) or is it something included with node? if so, I cannot find it...

[tim-smart]

Yes it's file maintained in the less lib folder. I noticed it was used
elsewhere in the code for base64 encoding.
On 11/06/2014 5:13 am, "Luke Page" notifications@github.com wrote:

Hi,

No, I'm not and that issue with node 0.8 is now fixed in master.

I may well be missing something, but where does "./encoder.js" come from?
its using a relative path as if its a file we maintain in the less libs
folder, but you didn't include it in your commit. If its a dependency it
would need adding to the package file (but I can't find an encoder package)
or is it something included with node? if so, I cannot find it...

—
Reply to this email directly or view it on GitHub
#2045 (comment).

[lukeapage]

Eek sorry I completely missed we had that :s