Change to less-browser for old android #2727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to check if tag.dataset.hasOwnProperty is a function to prevent errors in error reporting in apps that us web view in older versions of android (pre-4.4).
|
I'm not sure but isn't it a duty of the recommended polyfills? |
|
@namingFailed Did you tested it with es5-shim? It should add also hasOwnProperty if it is not available. Is there a reason not to use it? If shim does not work we should raise an issue there or/and merge this. If the shim does work, then we recommend to use the shim. Less.js assumes ECMAScript 5 compatibility and next version may use something else from it. You risk that something else will break again if you do not use the shim in old browsers. |
|
Closing due to lack of info on the purpose of this PR (and it looks like it's just missed http://lesscss.org/usage/#browser-support). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to check if tag.dataset.hasOwnProperty is a function to prevent
errors in error reporting in apps that use web view in older versions of
android (pre-4.4).