Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: browser cache is always considered stale if .modifyVars wasn't set #3239

Merged
merged 2 commits into from Jun 27, 2018
Merged

fix: browser cache is always considered stale if .modifyVars wasn't set #3239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed5bb51
fix: browser cache was always considered stale if .modifyVars wasn't set
balpha Jun 27, 2018
aeb9754
arguably better fix for the cache issue: always compare JSON
balpha Jun 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/less-browser/cache.js
View file
Open in desktop
Expand Up @@ -29,11 +29,12 @@ module.exports = function(window, options, logger) {
vars = cache && cache.getItem(path + ':vars');

modifyVars = modifyVars || {};
vars = vars || "{}"; // if not set, treat as the JSON representation of an empty object

if (timestamp && webInfo.lastModified &&
(new Date(webInfo.lastModified).valueOf() ===
new Date(timestamp).valueOf()) &&
(!modifyVars && !vars || JSON.stringify(modifyVars) === vars)) {
JSON.stringify(modifyVars) === vars) {
// Use local copy
return css;
}
Expand Down