Removes less-rhino (broken for a long time) - Fixes #3241
#3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinjuarez
reviewed
Jul 7, 2018
| @@ -154,8 +154,6 @@ module.exports = function (grunt) { | |||
| // Project configuration. | |||
| grunt.initConfig({ | |||
|
|
|||
| // Metadata required for build. | |||
| build: grunt.file.readYAML('build/build.yml'), | |||
There was a problem hiding this comment.
I don't know much about the whole Rhino deal. Was build/build.yml only used for building Less-Rhino? It looks like it was moved to build/build.yml.old anyway. If we're not using the file at all, is there any benefit to keeping it in the repo?
There was a problem hiding this comment.
I think it was just used for that. I ran the usual grunt tasks and I got no failures. Nor did I see references anywhere else for it. I'll see if I can delete it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Java is to be re-supported, it should go in a separate
less-javarepo (refactor #2985).