Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Promise polyfill for PhantomJS under Node 9 #3275

Merged
merged 2 commits into from
Jul 8, 2018
Merged

Adds Promise polyfill for PhantomJS under Node 9 #3275

merged 2 commits into from
Jul 8, 2018

Conversation

matthew-dean
Copy link
Member

Attempted fix, will run CI tests to see...

calvinjuarez
calvinjuarez requested changes Jul 7, 2018
View reviewed changes
Copy link
Member

@calvinjuarez calvinjuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the polyfill is being checked by ESLint and has failures there. We should probably add test/browser/vendor/ to the .eslintignore.

@matthew-dean
Copy link
Member Author

@calvinjuarez Passing! Merging.

@matthew-dean matthew-dean merged commit 8e814c7 into less:master Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinjuarez calvinjuarez calvinjuarez requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthew-dean @calvinjuarez