Fix #3698 #3373 - parsing variables fail when there is no trailing semicolon #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, thanks for taking a look at this! |
matthew-dean
approved these changes
May 4, 2022
iChenLei
approved these changes
May 5, 2022
|
Hi, Can we merge this pr? |
|
same here，can we merge this ? |
|
ping @matthew-dean |
|
Hi, is there any chance we can get a release of less with this fix in soon please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added a fix for the parser crashing when a css variable property does not end with a semicolon. Fixes #3698 and Fixes #3373.
Why:
This helps to avoid crashes when importing pre-minified css files from e.g. an npm package. In our case, cssnano always drops the trailing semicolon on the last property. This cannot be disabled without disabling all of whitespace normalization (
normalizeWhitespaceoption). Fixing the bug in Less.js fixes this use case for us.How:
When calling
permissiveValueon a detected css variable, theuntilTokensparameter is left unset. This defaults it to detecting;for ending the value. I've set the parameter to/[;}]/instead in order to close variables on either the semicolon (;) or the closing curly bracket (}) character. This may not be the most optimal fix, but it gets the job done in the test cases I've added. Additionally, it doesn't break any of the existing test cases.Checklist: