Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release string interpolation in @import statements. #426

Closed
wants to merge 1 commit into from

Conversation

anru
Copy link

@anru anru commented Oct 17, 2011

Warning! Many api changes!

@anru
Copy link
Author

anru commented Oct 17, 2011

api changes:
Parser.parse(str, callback(err, tree)) => tree = Parser.parse(str); // throws err;
css = tree.toCSS(options, vars) => tree.toCSS(options, vars).then(callback(css), errback(error));

And root's tree.Ruleset.eval returns promise object instead of evaled ruleset,
tree.Import.eval returns promise object too.

Also included when.js library for deferred functionality.

@arnaudgaudin
Copy link

Excellent ! Thank you very much, can't wait to test this new functionnality in my project ! Just hoping that leafo will add this to lessphp...

@cloudhead
Copy link
Member

what's with the API changes? If you want this merged, you'll have to open another pull request with only the relevant changes.

@anru
Copy link
Author

anru commented Oct 18, 2011

Without API changes ? it is hardly to possible, becouse toCSS() async operation if @import has string-interpolation (in contrast with Parser.parse)
Or without when.js library ? It makes sense, for ex. rewrite to use events.EventEmitter instead.

@paulyoung
Copy link

Not sure about the api changes, but a much needed feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants