newline all selectors whose combined length is greater than 25 chars #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, but now you're doing an extra join() for each selector, which could be expensive.. can the join be cached somehow? |
|
yeah... let me rethink this |
|
while loop seems to be the fastest thing i could come up with... http://jsperf.com/joining-selectors or we could just always newline? which would actually be the fastest |
|
tbh yea, I'd just always newline when there's more than 1 selector.. anything else is arbitrary. |
|
yeah - that was my first instinct too - good call |
cloudhead
pushed a commit
that referenced
this pull request
Jan 23, 2012
newline all selectors whose combined length is greater than 25 chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limit length of comma separated selectors to 25 chars before breaking out to separate lines.
Not totally sure if 25 is the best length - or if we should always newline selectors...