Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an argument to prompt for the [SITE] and [LOGIN] arguments #364

Merged
merged 9 commits into from
Dec 18, 2018
Merged

Adds an argument to prompt for the [SITE] and [LOGIN] arguments #364

merged 9 commits into from
Dec 18, 2018

Conversation

schlomie
Copy link
Contributor

For added security, this PR provides a [-p --prompt] argument which then allows a user to enter both the SITE and LOGIN arguments in the same manner they could enter the MASTER PASSWORD - without revealing their values in a terminal buffer, or recording them in bash history.

Usage:

$ lesspass -p -L 25
Site: 
Login: 
Master Password: 
ybnAY]&S?Vx\8L,96u!_?,;>J

edouard-lopez
edouard-lopez requested changes Dec 17, 2018
View reviewed changes
cli/tests/test_cli.py Outdated Show resolved Hide resolved
cli/lesspass/validator.py Show resolved Hide resolved
cli/lesspass/help.py Outdated Show resolved Hide resolved
cli/lesspass/cli.py Outdated Show resolved Hide resolved
cli/lesspass/core.py Outdated Show resolved Hide resolved
edouard-lopez and others added 7 commits December 17, 2018 12:32
@edouard-lopez @schlomie
Update cli/lesspass/help.py
b6d71ff 
Co-Authored-By: schlomie <1683217+schlomie@users.noreply.github.com>
@edouard-lopez @schlomie
Update cli/lesspass/cli.py
35646ea 
Co-Authored-By: schlomie <1683217+schlomie@users.noreply.github.com>
@schlomie
Update cli/lesspass/core.py
3cb1a1e
@edouard-lopez @schlomie
Update cli/lesspass/core.py
8767b93 
Co-Authored-By: schlomie <1683217+schlomie@users.noreply.github.com>
@schlomie
Merge branch 'master' of https://github.com/schlomie/lesspass
04b156c
@schlomie
Update cli/tests/test_cli.py
fe7902e
@schlomie
SITE required error message verbiage and validate prompt test
e7ed32a
@guillaumevincent guillaumevincent merged commit 9f77256 into lesspass:master Dec 18, 2018
@guillaumevincent
Copy link
Member

Thank you @schlomie
LessPass cli 6.1.0 is updated with your code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edouard-lopez edouard-lopez edouard-lopez requested changes

Assignees
No one assigned
Labels
💡 idea 🔒 security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schlomie @guillaumevincent @edouard-lopez