Fixed #24. Cast to int before === check

lesterchan · Dec 31, 2018 · 41981b0 · 41981b0
1 parent dfbf1f3
commit 41981b0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,5 +1,6 @@
 language: php
 php:
+  - "7.3"
   - "7.2"
   - "7.1"
   - "7.0"

diff --git a/wp-downloadmanager.php b/wp-downloadmanager.php
@@ -839,7 +839,7 @@ function download_rename_file($file_path, $file) {
 ### Function: Editable Timestamp
 function file_timestamp($file_timestamp) {
 	global $month;
-	$day = gmdate('j', $file_timestamp);
+	$day = (int) gmdate('j', $file_timestamp);
 	echo '<select id="file_timestamp_day" name="file_timestamp_day" size="1">'."\n";
 	for($i = 1; $i <=31; $i++) {
 		if($day === $i) {
@@ -849,7 +849,7 @@ function file_timestamp($file_timestamp) {
 		}
 	}
 	echo '</select>&nbsp;&nbsp;'."\n";
-	$month2 = gmdate('n', $file_timestamp);
+	$month2 = (int) gmdate('n', $file_timestamp);
 	echo '<select id="file_timestamp_month" name="file_timestamp_month" size="1">'."\n";
 	for($i = 1; $i <= 12; $i++) {
 		if ($i < 10) {
@@ -864,9 +864,10 @@ function file_timestamp($file_timestamp) {
 		}
 	}
 	echo '</select>&nbsp;&nbsp;'."\n";
-	$year = gmdate('Y', $file_timestamp);
+	$year = (int) gmdate('Y', $file_timestamp);
+	$current_year = (int) gmdate('Y');
 	echo '<select id="file_timestamp_year" name="file_timestamp_year" size="1">'."\n";
-	for($i = 2000; $i <= gmdate('Y'); $i++) {
+	for($i = 2000; $i <= $current_year; $i++) {
 		if($year === $i) {
 			echo "<option value=\"$i\" selected=\"selected\">$i</option>\n";
 		} else {
@@ -875,7 +876,7 @@ function file_timestamp($file_timestamp) {
 	}
 	echo '</select>&nbsp;@'."\n";
   echo '<span dir="ltr">'."\n";
-	$hour = gmdate('H', $file_timestamp);
+	$hour = (int) gmdate('H', $file_timestamp);
 	echo '<select id="file_timestamp_hour" name="file_timestamp_hour" size="1">'."\n";
 	for($i = 0; $i < 24; $i++) {
 		if($hour === $i) {
@@ -885,7 +886,7 @@ function file_timestamp($file_timestamp) {
 		}
 	}
 	echo '</select>&nbsp;:'."\n";
-	$minute = gmdate('i', $file_timestamp);
+	$minute = (int) gmdate('i', $file_timestamp);
 	echo '<select id="file_timestamp_minute" name="file_timestamp_minute" size="1">'."\n";
 	for($i = 0; $i < 60; $i++) {
 		if($minute === $i) {
@@ -896,7 +897,7 @@ function file_timestamp($file_timestamp) {
 	}
 
 	echo '</select>&nbsp;:'."\n";
-	$second = gmdate('s', $file_timestamp);
+	$second = (int) gmdate('s', $file_timestamp);
 	echo '<select id="file_timestamp_second" name="file_timestamp_second" size="1">'."\n";
 	for($i = 0; $i <= 60; $i++) {
 		if($second === $i) {