Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the poll on mobile, this message gets lost "You Had Alread… #67

Merged
merged 1 commit into from
Mar 15, 2016
Merged

Conversation

eduardoarandah
Copy link
Contributor

…y Voted For This Poll" because poll total height shrinks.

When user tries to vote again, the code shows a tiny message that gets lost on mobile versions because total height changes drastically.

Better aproach is showing poll results anyway, and a styled message on bottom.

…y Voted For This Poll" because poll total height shrinks.

Added a wrapper class to help style this message
lesterchan added a commit that referenced this pull request Mar 15, 2016
When using the poll on mobile, this message gets lost "You Had Alread…
@lesterchan lesterchan merged commit e6e9a21 into lesterchan:master Mar 15, 2016
@eduardoarandah
Copy link
Contributor Author

Although the behaviour is OK, I see a bug for this commit:

After trying to vote twice, appears a "loading" message that doesn't go away.

@lesterchan
Copy link
Owner

Are you using a caching plugin or something? Because technically speaking, you should not see 'You Had Already Voted For This Poll. Poll ID #%s' at all.

@eduardoarandah
Copy link
Contributor Author

Yes. W3 total Cache

El lunes, 14 de marzo de 2016, Lester Chan notifications@github.com
escribió:

Are you using a caching plugin or something? Because technically speaking,
you should not see 'You Had Already Voted For This Poll. Poll ID #%s' at
all.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#67 (comment)

Enviado desde mi móvil

@lesterchan
Copy link
Owner

Yap, that is the problem though, This plugin is not compatible with any caching plugin because those plugin caches the HTML page and this plugin doesn't load the initial poll via AJAX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants