This repository has been archived by the owner on May 31, 2023. It is now read-only.
Remove exception reporting from IllustrationView::OnCreate() #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a workaround for a problem in wxWidgets fixed a long time ago, see wxWidgets commit 7047d7981f (handle exceptions thrown from overridden wxView::OnCreate() gracefully, 2008-12-30) and is not needed any longer: no view is created if an exception is thrown from here. This commit is best viewed ignoring whitespace-only changes.
After removing the try/catch in the previous commit, this variable is not really useful any more, so remove it to simplify the code and make its logic more apparent. No real changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.