Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Remove exception reporting from IllustrationView::OnCreate() #208

Closed
wants to merge 2 commits into from
Closed

Remove exception reporting from IllustrationView::OnCreate() #208

wants to merge 2 commits into from

Commits on May 14, 2022

  1. Remove unneeded try/catch from IllustrationView::OnCreate() 

    This was a workaround for a problem in wxWidgets fixed a long time ago,
see wxWidgets commit 7047d7981f (handle exceptions thrown from
overridden wxView::OnCreate() gracefully, 2008-12-30) and is not needed
any longer: no view is created if an exception is thrown from here.

This commit is best viewed ignoring whitespace-only changes.
    @vadz
    vadz committed May 14, 2022
    Configuration menu
    Copy the full SHA
    0c07504 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary variable from IllustrationView::OnCreate() 

    After removing the try/catch in the previous commit, this variable is
not really useful any more, so remove it to simplify the code and make
its logic more apparent.

No real changes.
    @vadz
    vadz committed May 14, 2022
    Configuration menu
    Copy the full SHA
    d55ec4a View commit details
    Browse the repository at this point in the history