More swap wip #238
Merged
More swap wip #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snider
reviewed
Sep 20, 2022
|
|
||
| if (dst_entr.addr.is_swap_addr) { | ||
| // Zero key for swap txs | ||
| // TODO Should probably do all address math only when neccessary |
There was a problem hiding this comment.
Could we do an impossible key, like 000000000000000000000000000000000000000 ?
There was a problem hiding this comment.
Not sure, for now will just implement boolberry logic. Will have some free time by the end of the week, then i will give some more precise answer.
Snider
reviewed
Sep 20, 2022
| @@ -17,6 +18,46 @@ TEST(swap_address, swap_addr_extra_userdata_entry_from_addr) | |||
| ASSERT_TRUE(entry.is_checksum_valid()); | |||
| } | |||
|
|
|||
| TEST(swap_address, swap_parse_addr_from_str) | |||
There was a problem hiding this comment.
Yay, code with a test, we are like adults now... my word, what happened :P
|
are you able to merge @bubafistah ? if not its time you get super cow powers. |
|
@bubafistah, well, I'm going to get out of your way; time for you to spread your wings and be the blockchain lead ( I'm still here to make you'll smile and review changes) Need me to do anything, ask, and it won't be a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address parsing, tx constructing wip, etc.
Based on https://github.com/cryptozoidberg/boolberry