Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and test on arm64 mac #219

Merged
merged 7 commits into from
Feb 15, 2024
Merged

build and test on arm64 mac #219

merged 7 commits into from
Feb 15, 2024

Conversation

jakevc
Copy link
Contributor

@jakevc jakevc commented Feb 8, 2024

Adds build and test CI for arm64 Mac

@jakevc
Copy link
Contributor Author

jakevc commented Feb 8, 2024

Might fix #218 if build and test work on arm64

@letmaik
Copy link
Owner

letmaik commented Feb 8, 2024

Could you try this in your own fork first? I don't think this is correct and GitHub also hasn't released free arm64 Mac agents yet.

@kmilos
Copy link
Contributor

kmilos commented Feb 8, 2024

GitHub also hasn't released free arm64 Mac agents yet.

Au conratire! Just last week: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Has to be macos-14 though, latest still points to 12 (Intel)...

As for the rest, seems overly complex indeed... Why not use a matrix instead of duplicating all this stuff?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@letmaik
Copy link
Owner

letmaik commented Feb 8, 2024

GitHub also hasn't released free arm64 Mac agents yet.

Au conratire! Just last week: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Has to be macos-14 though, latest still points to 12 (Intel)...

You're right, I totally missed that. That's great!

As for the rest, seems overly complex indeed... Why not use a matrix instead of duplicating all this stuff?

I wasn't able to express all the different cases with a matrix and it seemed that listing every config was more straight forward to manage.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jakevc
Copy link
Contributor Author

jakevc commented Feb 13, 2024

Passing build and test here now: https://github.com/jakevc/rawpy/actions/runs/7879645476

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jakevc
Copy link
Contributor Author

jakevc commented Feb 15, 2024

All checks have passed for this

@letmaik letmaik merged commit 3915477 into letmaik:main Feb 15, 2024
45 checks passed
@letmaik
Copy link
Owner

letmaik commented Feb 15, 2024

Thanks! :)

@jakevc jakevc deleted the ci/arm64 branch February 16, 2024 18:56
@jakevc
Copy link
Contributor Author

jakevc commented Feb 20, 2024

please release this version to PyPi when you get the chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants