Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl support #9

Closed
liadya opened this issue Aug 15, 2018 · 4 comments
Closed

rtl support #9

liadya opened this issue Aug 15, 2018 · 4 comments

Comments

@liadya
Copy link

liadya commented Aug 15, 2018

Please add support for right to left layouts/languages (Hebrew for example),
for example, cannot change the location of the SliverStickyHeader.header to be located on the right side of the list.

@letsar letsar self-assigned this Aug 21, 2018
@letsar letsar added the enhancement New feature or request label Aug 21, 2018
@letsar
Copy link
Owner

letsar commented Aug 21, 2018

Hi @liadya,
Thanks for this issue, I will add this to the next version 😃 !

@letsar
Copy link
Owner

letsar commented Aug 21, 2018

I ran more tests and in fact, my header was built like this:

return new Container(
  height: 60.0,
  color: Colors.lightBlue,
  padding: EdgeInsets.symmetric(horizontal: 16.0),
  alignment: Alignment.centerLeft,
  child: new Text(
    text ?? 'Header #$index',
    style: const TextStyle(color: Colors.white),
  ),
);

In my case the alignment was hard coded to centerLeft.

If I only set a Text, it is correctly rendered with the proper text direction. So this widget already supports Ltr and Rtl text directions 😃.

Can you paste here the method you used to create your headers?

@letsar letsar added waiting for user response and removed enhancement New feature or request labels Aug 22, 2018
@liadya
Copy link
Author

liadya commented Sep 25, 2018 via email

@letsar
Copy link
Owner

letsar commented Sep 25, 2018

Hi @liadya ,

Ok no problem, I will close this issue then.
With which implementation did you move forward?

Thanks for your feedback 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants